Add OptimizerConfig and SchedulerConfig
#135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisCastricato
approved these changes
Dec 14, 2022
| return dist_config | ||
|
|
||
|
|
||
| class OptimizerNames(Enum): |
There was a problem hiding this comment.
Why are we not using registers...?
There was a problem hiding this comment.
Adding a registry for str types seemed like a pre-mature abstraction given that the source is local to a single file. What exactly are you suggesting?
There was a problem hiding this comment.
Fair, Dw then. Ready for merging imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following configuration updates:
Adds an
OptimizerConfigdedicated to customizing optimizer specifications.torch.optim.AdamW.introduced in PR Add
bitsandbytesoptimizer support #133Adds a
SchedulerConfigfor customizing the learning rate scheduler.torch.optim.lr_scheduler.CosineAnnealingLR; this opens possibilities for other schedulers liketorch.optim.lr_scheduler.OneCycleLRif desired from the communityNotes:
consistent.
wandbreports: PPO/ILQL Sentiments@ reviewer: I found these updates useful to me; if this feature is not desired or designed appropriately feel free to suggest edits or close.