Skip to content

Simplifying logic to merge configs #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2022
Merged

Simplifying logic to merge configs #134

merged 2 commits into from
Dec 14, 2022

Conversation

leshanbog
Copy link
Contributor

@leshanbog leshanbog commented Dec 13, 2022 •
edited
Loading

Simplification of merging config logic

@LouisCastricato
Copy link
Contributor

? Can you explain what this PR is for and why these changes are necessary. We won't merge or even consider a PR without a proper description.

@leshanbog leshanbog changed the title Updating default config Simplifying logic to merge configs Dec 14, 2022
@LouisCastricato LouisCastricato merged commit 1320409 into CarperAI:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LouisCastricato LouisCastricato LouisCastricato approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leshanbog @LouisCastricato