Skip to content

Set seed after default config instantiation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Set seed after default config instantiation #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion trlx/trlx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ def train(
split_token (Optional[str]): Split samples in the dataset on prompts and continuations
logit_mask (Optional[List]): Bigram masking matrix
"""
set_seed(config.train.seed)
if reward_fn is not None:
if config is None:
config = TRLConfig.load_yaml("configs/ppo_config.yml")
set_seed(config.train.seed)

if model_path:
config.model.model_path = model_path
Expand Down Expand Up @@ -67,6 +67,7 @@ def train(

if config is None:
config = TRLConfig.load_yaml("configs/ilql_config.yml")
set_seed(config.train.seed)

if model_path:
config.model.model_path = model_path
Expand Down