-
Notifications
You must be signed in to change notification settings - Fork 482
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
🐛 Describe the bug
First off, I'd like to say that this is an excellent repo.
However, I did notice that the default tokenizer config sets padding_side=left, which seems to be different from the common default of right in most NLP tokenizers. While I understand that setting padding_side to right might be more convenient when calculating advantages, I think it could potentially lead to bugs if users are allowed to modify it. Would it be safer to prevent users from modifying the padding side?
Which trlX version are you using?
newest
Additional system and package information
No response
zmsn-2077
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working