Skip to content

can padding_side be 'right'? #424

@ry-sun

Description

@ry-sun

🐛 Describe the bug

First off, I'd like to say that this is an excellent repo.

However, I did notice that the default tokenizer config sets padding_side=left, which seems to be different from the common default of right in most NLP tokenizers. While I understand that setting padding_side to right might be more convenient when calculating advantages, I think it could potentially lead to bugs if users are allowed to modify it. Would it be safer to prevent users from modifying the padding side?

Which trlX version are you using?

newest

Additional system and package information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions