Skip to content

Conversation

oscartbeaumont
Copy link
Member

@oscartbeaumont oscartbeaumont commented Aug 27, 2025

  • Only show main if no other windows are open?
Screenshot 2025-09-03 at 11 47 24 am

Summary by CodeRabbit

  • New Features
    • Windows: After closing the Editor window, the main capture window now automatically reappears.
    • macOS & Linux: No behavioral changes; existing flow unchanged.
    • Deployment: Works out of the box—no user settings or updates required.

Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Walkthrough

Adds a Windows-only code path in run(recording_logging_handle) that, after removing an Editor window, invokes ShowCapWindow::Main.show(&app). The call is compiled only on Windows and its Result is ignored (.ok()); other platforms remain unchanged.

Changes

Cohort / File(s) Summary
Windows post-editor-close handling
apps/desktop/src-tauri/src/lib.rs
Adds a Windows-gated block that, after Editor window removal, calls ShowCapWindow::Main.show(&app).ok() to request showing the Main Cap window. No public API changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant EditorWindow
  participant App
  participant ShowCapWindow
  participant MainCapWindow

  User->>EditorWindow: Close Editor
  EditorWindow-->>App: notify window removed
  App->>App: remove Editor window (all platforms)

  alt Windows (#[cfg(windows)])
    App->>ShowCapWindow: ShowCapWindow::Main.show(&app)
    Note right of ShowCapWindow #E6F4EA: Result ignored via .ok()
    ShowCapWindow-->>MainCapWindow: display request
    MainCapWindow-->>User: Main Cap visible
  else Other platforms
    Note over App: no additional action
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudged the pane and watched it slide,
On Windows, Main Cap hops inside.
A quiet hop, no frantic cries,
Errors tucked where silence lies.
A rabbit's joy — two windows, wise. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 525cbcf and 759db27.

📒 Files selected for processing (1)
  • apps/desktop/src-tauri/src/lib.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/desktop/src-tauri/src/lib.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
  • GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
  • GitHub Check: Analyze (rust)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch open-main-after-closing-editor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d39b4ee and 1dfe485.

📒 Files selected for processing (1)
  • apps/desktop/src-tauri/src/lib.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/desktop/src-tauri/**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

Use tauri_specta on the Rust side for IPC (typed commands/events) and emit events via generated types

Files:

  • apps/desktop/src-tauri/src/lib.rs
🧬 Code graph analysis (1)
apps/desktop/src-tauri/src/lib.rs (1)
apps/desktop/src/utils/tauri.ts (1)
  • ShowCapWindow (435-435)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
  • GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
  • GitHub Check: Analyze (rust)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants