-
Notifications
You must be signed in to change notification settings - Fork 740
feat: Recording area border color. Cropper improvements and fixes #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
…er color Default haptic performance time is now DrawCompleted. Haptics can be disabled on macOS within the System Settings.
…ly close menus Improve the layering (and paint performance) of Cropper for less memory use on update
…close" capability missing
New Feature:
The active recording area now shows a customizable border color.
New Aspect option within the Cropper:
Fixes
Also added a button to close the window on the error boundary page. Before this you had to kill the app if any undecorated, always on top fullscreen windows threw an error.
Notes:
Memory usage for the Cropper has been drastically improved during resizing by avoiding Solid's reactivity and directly setting the position for the invisible controls. They no longer update during resize and only appear afterwards.
This really bothered me since I accidentally noticed it in Activity Monitor and couldn't figure out what was causing it.
Before this fix, the constant updates and changes caused the usage to jump over 500MB (on macOS) during resize.
Right clicking on the Cropper now shows a new Aspect option. If there isn't a required aspect ratio set by the parent of Cropper, the user can select one instead of trying to align and snap the selection to a preferred aspect.