New recording flow #2874
ci.yml
on: pull_request
Detect Changes
8s
Typecheck
53s
Format (Biome)
9s
Format (Cargo)
13s
Lint (Biome)
11s
Matrix: Build Desktop
Annotations
2 errors, 10 warnings, and 3 notices
Typecheck
Process completed with exit code 2.
|
Typecheck:
apps/desktop/src/routes/target-select-overlay.tsx#L40
Object literal may only specify known properties, and 'screen' does not exist in type 'TargetUnderCursor'.
|
this `else { if .. }` block can be collapsed:
crates/rendering/src/layout.rs#L125
warning: this `else { if .. }` block can be collapsed
--> crates/rendering/src/layout.rs:125:16
|
125 | } else {
| ________________^
126 | | if let Some(prev_segment) = cursor.prev_segment {
127 | | if cursor.time < prev_segment.end + 0.05 {
128 | | (prev_segment.mode.clone(), LayoutMode::Default, 1.0)
... |
135 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
125 ~ } else if let Some(prev_segment) = cursor.prev_segment {
126 + if cursor.time < prev_segment.end + 0.05 {
127 + (prev_segment.mode.clone(), LayoutMode::Default, 1.0)
128 + } else {
129 + (LayoutMode::Default, LayoutMode::Default, 1.0)
130 + }
131 + } else {
132 + (LayoutMode::Default, LayoutMode::Default, 1.0)
133 ~ };
|
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L101
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:101:40
|
101 | (segment.mode.clone(), segment.mode.clone(), 1.0)
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `segment.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L101
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:101:18
|
101 | (segment.mode.clone(), segment.mode.clone(), 1.0)
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `segment.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L95
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:95:25
|
95 | segment.mode.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `segment.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L89
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:89:25
|
89 | next_seg.mode.clone(),
| ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `next_seg.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L88
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:88:25
|
88 | segment.mode.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `segment.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L81
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:81:21
|
81 | segment.mode.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `segment.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `LayoutMode` which implements the `Copy` trait:
crates/rendering/src/layout.rs#L76
warning: using `clone` on type `LayoutMode` which implements the `Copy` trait
--> crates/rendering/src/layout.rs:76:30
|
76 | .map(|s| s.mode.clone())
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.mode`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
unneeded `return` statement:
crates/cursor-capture/src/position.rs#L52
warning: unneeded `return` statement
--> crates/cursor-capture/src/position.rs:52:13
|
52 | / return Some(Self {
53 | | x: raw.x - logical_bounds.position().x() as i32,
54 | | y: raw.y - logical_bounds.position().y() as i32,
55 | | display,
56 | | });
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
52 ~ Some(Self {
53 + x: raw.x - logical_bounds.position().x() as i32,
54 + y: raw.y - logical_bounds.position().y() as i32,
55 + display,
56 ~ })
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
crates/scap-ffmpeg/src/cpal.rs#L30
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> crates/scap-ffmpeg/src/cpal.rs:30:49
|
30 | let plane_size = sample_count * sample_size as usize;
| ^^^^^^^^^^^^^^^^^^^^ help: try: `sample_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
Clippy
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
Build Desktop (aarch64-apple-darwin, macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
Build Desktop (x86_64-pc-windows-msvc, windows-latest)
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677
|