Skip to content

Conversation

@goldmedal
Copy link
Collaborator

@goldmedal goldmedal commented Sep 22, 2025

Reverts #1887

Summary by CodeRabbit

  • Refactor

    • Removed Microsoft SQL Server (MSSQL) data source support from dbt profile conversion and related tooling.
    • Dropped the "server" field from connection profiles.
    • Port values must now be numeric (int/float); string ports are no longer parsed.
  • Impact

    • Existing MSSQL profiles will no longer be recognized or generated.
    • Update profiles to use supported data sources (e.g., Postgres, MySQL) and ensure port values are numbers.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 02bb00b and 81ee467.

📒 Files selected for processing (5)
  • wren-launcher/commands/dbt/converter.go (0 hunks)
  • wren-launcher/commands/dbt/data_source.go (1 hunks)
  • wren-launcher/commands/dbt/data_source_test.go (0 hunks)
  • wren-launcher/commands/dbt/profiles.go (0 hunks)
  • wren-launcher/commands/dbt/profiles_analyzer.go (1 hunks)
 ____________________________________________________________________________________________________________________________________________________________________
< Use blackboards to coordinate workflow. Use blackboards to coordinate disparate facts and agents, while maintaining independence and isolation among participants. >
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting in your project's settings in CodeRabbit to disable sequence diagrams in the walkthrough.

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-1887-chore/dbt-mssql

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@douenergy douenergy merged commit 3edba06 into main Sep 22, 2025
6 of 7 checks passed
@goldmedal goldmedal deleted the revert-1887-chore/dbt-mssql branch September 22, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants