Skip to content

Improve pgn parsing #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2025
Merged

Improve pgn parsing #13

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7039c0
fix(parsing): Not all games begin from move 1
CalvoM Aug 2, 2025
90bc3d6
fix(game analysis): Make sure that both usernames are same case
CalvoM Aug 2, 2025
fbc96a5
perf(archives): Improve performance of archive retrieval
CalvoM Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion style_predictor/pgn_parser/file_processing/lexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def lex(self) -> None | list[Token]:
case "\n":
_ = self.read()
self._cr_pos()
if self.peek() == "1":
if self.peek() and self.peek().isdigit():
self.lex_movetext()
# break
case None:
Expand Down
6 changes: 3 additions & 3 deletions style_predictor/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def get_games_analysis(
Returns:
Dict with statistical analysis of the games provided.
"""
names = {n.strip() for n in username.split("||")}
names = {n.strip().lower() for n in username.split("||")}
total = len(pgn_games)
wins = losses = draws = 0
opp_mapping: list[tuple[int, int | None]] = []
Expand All @@ -254,8 +254,8 @@ def get_games_analysis(
if eco_code := tags.get("ECO", None):
opening_mapper.append((eco_code, " ".join([str(move) for move in g.moves])))

is_white = white in names
is_black = black in names
is_white = white.lower() in names
is_black = black.lower() in names

# win/loss/draw
if result == constants.DRAW:
Expand Down