Skip to content

Two fixes for OpenAPI 2.0 version of the API (take 2). #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Two fixes for OpenAPI 2.0 version of the API (take 2). #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69fe535
Fix currentpage parameter: it should be in the query, not the path.
zhirsch Sep 30, 2017
6f2f3b9
Fix components parameter: OpenAPI 2.0 does not allow $ref in query pa…
zhirsch Sep 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions openapi-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,7 +2251,7 @@
"parameters": [
{
"name": "currentpage",
"in": "path",
"in": "query",
"description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.",
"required": true,
"type": "integer",
Expand Down Expand Up @@ -2331,7 +2331,7 @@
"parameters": [
{
"name": "currentpage",
"in": "path",
"in": "query",
"description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.",
"required": true,
"type": "integer",
Expand Down Expand Up @@ -2741,7 +2741,7 @@
"parameters": [
{
"name": "currentpage",
"in": "path",
"in": "query",
"description": "Page number (starting with 1). Each page has a fixed size of 50 entries.",
"required": true,
"type": "integer",
Expand Down Expand Up @@ -2958,7 +2958,7 @@
"parameters": [
{
"name": "currentpage",
"in": "path",
"in": "query",
"description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.",
"required": true,
"type": "integer",
Expand Down Expand Up @@ -3024,7 +3024,7 @@
"parameters": [
{
"name": "currentpage",
"in": "path",
"in": "query",
"description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.",
"required": true,
"type": "integer",
Expand Down Expand Up @@ -3935,8 +3935,9 @@
"description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.DestinyComponentType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "destinyMembershipId",
Expand Down Expand Up @@ -4020,8 +4021,9 @@
"description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.DestinyComponentType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "destinyMembershipId",
Expand Down Expand Up @@ -4148,8 +4150,9 @@
"description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.DestinyComponentType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "destinyMembershipId",
Expand Down Expand Up @@ -4242,8 +4245,9 @@
"description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.DestinyComponentType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "destinyMembershipId",
Expand Down Expand Up @@ -4332,8 +4336,9 @@
"description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.DestinyComponentType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "destinyMembershipId",
Expand Down Expand Up @@ -5252,8 +5257,9 @@
"description": "Group of stats to include, otherwise only general stats are returned. Comma separated list is allowed. Values: General, Weapons, Medals",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyStatsGroupType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "membershipType",
Expand All @@ -5278,8 +5284,9 @@
"description": "Game modes to return. See the documentation for DestinyActivityModeType for valid values, and pass in string representation, comma delimited.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyActivityModeType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "periodType",
Expand Down Expand Up @@ -5356,8 +5363,9 @@
"description": "Groups of stats to include, otherwise only general stats are returned. Comma separated list is allowed. Values: General, Weapons, Medals.",
"type": "array",
"items": {
"$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyStatsGroupType"
}
"type": "integer"
},
"collectionFormat": "csv"
},
{
"name": "membershipType",
Expand Down