Skip to content

Add localStorage #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add localStorage #80

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
801e4cb
Save in local storage
Ystea Feb 25, 2016
5a33ce6
Load local storage ok
Ystea Feb 25, 2016
d9237d0
Local storage Ok
Ystea Feb 25, 2016
a9f0e29
correct line 429
Feb 29, 2016
aa26578
correct == and move loadEditorCOntent to updateUI
Ystea Mar 10, 2016
f6f0ead
tests for commits
Ystea Mar 31, 2016
5469208
test for getting last commit
aagez Apr 21, 2016
7b7dfe2
missing programing language
Ystea Apr 21, 2016
d400e6c
test changes : getCommit
aagez Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions public/app/exercise/exercise.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@
exercise.idle = false;
connection.sendMessage('userBack', {});
}
// Save the editor content in the local storage
$window.localStorage.setItem("editor." + exercise.id + "." + editor.getOption("mode"), editor.getValue());
startIdleLoop();
}

Expand All @@ -157,6 +159,13 @@
exercise.editor.on('change', resetIdleLoop);
resizeCodeMirror();
};


function loadEditorContent() {
var editorValue = $window.localStorage.getItem("editor." + exercise.id + "." + editor.getOption("mode"));
if (editorValue != null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of the common best practices to use === and !== instead of == and != to prevent type coercion during comparison.
For more details about type coercion and why we want to avoid it, you can check this link: http://blog.jeremymartin.name/2008/03/understanding-loose-typing-in.html

editor.setValue(editorValue);
}

function getExercise() {
var args = {
Expand Down Expand Up @@ -212,6 +221,8 @@
exercise.id = data.id;
exercise.name = data.id.split('.').pop();

loadEditorContent();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, since the value of the editor is overriden a few lines later by exercise.code = data.code.trim();.
The editor is kept up to date with the variable exercise.code using directive from AngularJS ng-model = exercise.code


navigation.setInlesson(true);
navigation.setCurrentPageTitle(exercise.lessonName + ' / ' + exercise.name);

Expand Down Expand Up @@ -468,8 +479,8 @@
exercise.resultType = null;
exercise.result = '';
exercise.logs = '';

exercisesList.setCurrentLessonID(exercise.lessonID);

}

function updateInstructions(instructions, api) {
Expand Down Expand Up @@ -793,6 +804,7 @@
break;
}
}
loadEditorContent();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setIDEMode() should not update the value of the editor, it is not its purpose.
It would be better to let updateUI() update it if needed.

}

function toggleAPI() {
Expand Down Expand Up @@ -848,4 +860,4 @@
}
return buffer;
}
})();
})();