Fix for REST query string URL encoding #7795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caused handlebars statements to break, this rectifies that.
Codecov Report
@@ Coverage Diff @@
## master #7795 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 125 125
Lines 4162 4162
Branches 655 655
=======================================
Hits 2821 2821
Misses 941 941
Partials 400 400
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shogunpurple
approved these changes
Sep 15, 2022
...ges/builder/app/[application]/data/datasource/[selectedDatasource]/rest/[query]/index.svelte
Outdated
Show resolved
Hide resolved
| @@ -46,7 +48,19 @@ export function buildQueryString(obj) { | |||
| if (str !== "") { | |||
| str += "&" | |||
| } | |||
| str += `${key}=${encodeURIComponent(value || "")}` | |||
| const bindings = findHBSBlocks(value) | |||
There was a problem hiding this comment.
It would be really good to have a test for this, if possible
There was a problem hiding this comment.
Did my best to get jest tests working in the builder, had to remove some of the old (disabled) jest tests as they just don't work anymore and probably need re-thought.
This is probably something we need to extend out further - cypress is great but jest tests are nice for little unit test type things. I've made the (limited) builder tests part of CI so that they hopefully offer some value from here forward.
…ts working in builder.
shogunpurple
approved these changes
Sep 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing issue introduced by fix for #7683 - encoding the query string caused handlebars statements to break, this rectifies that.
Also minor fix for z-index issue with a tooltip.
Addresses: