Skip to content

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Aug 11, 2025

Description

This PR updates our model selector to have the three new GPT-5 models and some accompanying updates around parameters to support this.

  • Removed the old GPT turbo models from the options. I can't really see a use case where you would ever want to use these. And gpt-4-turbo is more expensive than even gpt-5 (per token, it might generate less i suppose).
  • Update the OpenAI library to 5.X.X

Launchcontrol

  • Allow selection of GPT-5 in the AI model settings

@PClmnt PClmnt requested a review from a team as a code owner August 11, 2025 08:25
@PClmnt PClmnt requested review from adrinr and removed request for a team August 11, 2025 08:25
Copy link

qa-wolf bot commented Aug 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Aug 11, 2025
@PClmnt PClmnt marked this pull request as draft August 12, 2025 09:33
@PClmnt PClmnt marked this pull request as ready for review August 12, 2025 14:47
Copy link
Contributor

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job working this out - seems like it was a real pain! Just to check, does this mean we are now using the unidici approach for our mock model responses, but nock everywhere else?
If there is a specific error you remember seeing, could be worth documenting somewhere what to do if you need to mock a builtin node fetch.

@PClmnt
Copy link
Collaborator Author

PClmnt commented Aug 14, 2025

Amazing job working this out - seems like it was a real pain! Just to check, does this mean we are now using the unidici approach for our mock model responses, but nock everywhere else? If there is a specific error you remember seeing, could be worth documenting somewhere what to do if you need to mock a builtin node fetch.

That's right, yea. I know it's not ideal but migrating everything over from Nock seemed like being more of a pain. And at least now we have a reasonable concept of how to do this, as we will certainly start to see it as more libs start to move towards undici / internal fetch over node-fetch

@PClmnt PClmnt merged commit 19ac580 into master Aug 15, 2025
30 checks passed
@PClmnt PClmnt deleted the feat/update-ai-models branch August 15, 2025 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants