Skip to content

Skip migrations doc on replication #16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Aug 4, 2025

Description

Skip migrations doc on replication. This document should have a snapshot on the migrations that ran on that specific database, so replicating it just adds some room for bugs and we lose visibility on over what happened. The only exception is on creation, given that we want to carry over the existing migrations from the source database

Copy link

qa-wolf bot commented Aug 4, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Aug 4, 2025
@adrinr adrinr requested a review from mike12345567 August 4, 2025 08:51
@adrinr adrinr marked this pull request as ready for review August 4, 2025 09:07
@adrinr adrinr requested a review from a team as a code owner August 4, 2025 09:07
@github-actions github-actions bot added the size/m label Aug 4, 2025
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice job finding this!

@adrinr adrinr merged commit 2a5041a into master Aug 4, 2025
30 checks passed
@adrinr adrinr deleted the skip-migrations-doc-on-replication branch August 4, 2025 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants