OIDC PKCE support #16657
Merged
OIDC PKCE support #16657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
shogunpurple
approved these changes
Aug 1, 2025
shogunpurple
reviewed
Aug 1, 2025
adrinr
approved these changes
Aug 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for PKCE (https://oauth.net/2/pkce/) for code word challenges into the OIDC SSO flow.
I have added a new container to the worker test suite: https://github.com/dexidp/dex
This allows us to run an IDP which we can connect to with OIDC and confirm the validation flow properly.
The new integration test walks through a basic OIDC SSO login and confirms the token flows using the PKCE strategy.
Screenshots
Adds a new section to the OIDC configuration page to apply the PKCE challenge option (plain or S256).