upgrade-tests: support running against multiple apps, support sending extra jest args #16596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When no --app option is specified, tests now run against all apps in fixtures - Import all fixture apps upfront after starting the old container - Run pre-upgrade and post-upgrade tests for each app sequentially - Fix context file collisions by including app name in hash calculation - Add TEST_APP_NAME environment variable to pass current app to test process - Improve console output to show which app is being tested - Maintain backward compatibility for single app mode with --app option 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the upgrade-tests package to support testing multiple apps simultaneously and allows passing additional Jest arguments for more flexible test execution. The changes improve the testing workflow by defaulting to test all available fixture apps while maintaining backward compatibility for single app testing.
- Adds multi-app testing support by running against all apps in src/fixtures by default
- Enables passing extra Jest arguments to filter or customize test execution
- Simplifies CI workflow by removing per-app matrix strategy in favor of testing all apps together
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/upgrade-tests/src/utils/upgradeTest.ts | Adds TEST_APP_NAME environment variable requirement for context file naming |
| packages/upgrade-tests/src/cli/testRunner.ts | Adds support for testAppName option and extraArgs parameter passing to Jest |
| packages/upgrade-tests/src/cli/index.ts | Implements multi-app testing logic and Jest argument forwarding |
| packages/upgrade-tests/package.json | Adds @commander-js/extra-typings dependency for better CLI argument handling |
| .github/workflows/upgrade-tests.yml | Simplifies CI workflow to test all apps together instead of separate matrix jobs |
adrinr
approved these changes
Jul 24, 2025
PClmnt
approved these changes
Jul 24, 2025
mike12345567
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quality of life stuff here:
yarn test:upgrade --from 3.9.0 src/tests/automation.upgrade.spec