Improve migration integrity tests #16577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
reviewed
Jul 21, 2025
Comment on lines
62
to
63
| expect(latestDevDocs).toEqual(devDocs) | ||
| expect(latestProdDocs).toEqual(prodDocs) |
There was a problem hiding this comment.
Are these valid assertions? Aren't migrations by definition going to change some documents?
There was a problem hiding this comment.
This is what this test is testing. Each migration should be idempotent, and you should be able to run it multiple times. If it succeeded once, subsequent runs should not change anything (as everything is migrated already). I renamed the variables to make it more verbose
There was a problem hiding this comment.
Ahhh I totally misunderstood, the rename is much better. Thank you 🙏
samwho
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the way we run the migration integrity tests to use the
migrationProcessor. As the logic in there changed, with migrations and app syncs, we want to replicate the same flow.Along the way, I realised that we are updating the createdAt/updatedAt wrongly on user sync. Fixed it and added some tests for it