Skip to content

Conversation

@dittops
Copy link
Contributor

@dittops dittops commented Jun 9, 2025

No description provided.

@dittops dittops closed this Jul 24, 2025
sinanmohd pushed a commit that referenced this pull request Jul 25, 2025
Fix: performance metrics, input sync
sinanmohd pushed a commit that referenced this pull request Aug 5, 2025
vsraccubits added a commit that referenced this pull request Aug 22, 2025
athul-ab added a commit that referenced this pull request Nov 16, 2025
…, and z-index

Fixes 4 critical issues in OAuth connector authentication flow:

**Issue #1: URL Parameter Pollution**
- Removed URL manipulation from useOAuthCallback hook
- AgentDrawer now single source of truth for URL updates
- Prevents duplicate prompt IDs in URL

**Issue #2: Double Agent Box Creation**
- Added OAuth callback detection in AgentDrawer
- Prevents creating new session during OAuth flow
- Preserves original session instead of duplicating

**Issue #3: URL Cleanup Strategy**
- Updated ConnectorDetails to preserve agent/prompt params
- Only removes OAuth-specific params (code, state, connector)
- Fixes race condition between multiple URL cleanups

**Issue #4: Z-Index Stacking**
- Set AgentDrawer z-index to 1050
- Ensures AgentDrawer appears above AddAgent drawer
- Proper visual hierarchy maintained

**Files Changed:**
- src/hooks/useOAuthCallback.ts: Removed URL manipulation logic
- src/components/agents/AgentDrawer.tsx: Added OAuth detection + z-index fix
- src/components/agents/tools/ConnectorDetails.tsx: Selective URL cleanup

**Testing:**
- OAuth flow now preserves single session
- URL correctly shows single prompt ID
- OAuth params properly cleaned up
- Drawer stacking order corrected

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants