Reduce install size for linux glibc/musl #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Brooooooklyn
force-pushed
the
add-install-script-gnu-musl
branch
from
267b389 to
8e6c7e8
Compare
|
Looks like it worked 👍 https://packagephobia.com/result?p=@napi-rs/[email protected] |
|
Definitely ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, linux installs both glibc and musl binaries.
This PR adds the
installscript to prevent installing unused binaries, reducing the install size.We originally thought this could be added to Node.js core and thus npm but it was rejected.