Skip to content

Load dependencies urls over https #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

Load dependencies urls over https #312

merged 1 commit into from
Nov 26, 2019

Conversation

@JovicaSusa
Copy link
Contributor

No description provided.

@JovicaSusa JovicaSusa requested a review from thilonel October 15, 2019 12:44
thilonel
thilonel approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@thilonel thilonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work? Have you tested it?

@JovicaSusa
Copy link
Contributor Author

@thilonel I tried to open urls and they worked, didn't run app locally though(not sure how 😕 )

@thilonel thilonel merged commit 5021c08 into master Nov 26, 2019
@thilonel thilonel deleted the load-urls-over-https branch November 26, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thilonel thilonel thilonel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JovicaSusa @thilonel