Skip to content

Conversation

@adamgrad
Copy link
Member

No description provided.

@adamgrad adamgrad self-assigned this Dec 20, 2018
@adamgrad adamgrad requested a review from Azdaroth December 20, 2018 12:05
@adamgrad
Copy link
Member Author

@Azdaroth do you need a screenshot or some sort of screencast to review this?

@Azdaroth
Copy link
Member

@adamgrad No, I trust that you checked it, since you know how it's supposed to look like

@Azdaroth
Copy link
Member

@adamgrad it will be better to have all docs for Inbox in one PR, we can't just release docs for one endpoint

@adamgrad
Copy link
Member Author

@Azdaroth it's done, could you give it a look?

Copy link
Member

@Azdaroth Azdaroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, we certainly need Hosts endpoint documented as well

@@ -0,0 +1,30 @@
{
"links": {
"attachments.account": "http://test.host/api/v3/accounts/{attachments.account}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to replace test.host with www.bookingsync.com everywhere

"conversation": 3,
"member": {
"id": 5,
"type": "Host"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, in that case we need docs for /hosts endpoint but that could be a separate PR

closed_at | [Time](/reference/enums#formats) | Read | Time when Converstation has been closed at.
deadline_response_at | [Time](/reference/enums#formats) | Read | Conversation's deadline response time.
last_message_at | [Time](/reference/enums#formats) | Read | Conversation's last message time.
marked_as_spam_at | [Time](/reference/enums#formats) | Read | Time when Conversation has been marked as spam.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been -> was, since we know the exact time

---------------------|---------|------------|------------
created_at | [Time](/reference/enums#formats) | Read | Conversation's create time.
updated_at | [Time](/reference/enums#formats) | Read | Conversation's update time.
closed_at | [Time](/reference/enums#formats) | Read | Time when Converstation has been closed at.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been -> was, we know the exact time

---------------------|---------|------------|------------
id | Integer | Read | Message's id.
---------------------|---------|------------|------------
channel | String | Read | Message's channel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should link to some whitelisted channels

channel | String | Read | Message's channel.
content | Text | Read | Message's content.
origin | String | Read | Message's origin.
visibility | String | Read | Message's visibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should link to some whitelisted visibility options

---------------------|---------|------------|------------
created_at | [Time](/reference/enums#formats) | Read | Message's create time.
updated_at | [Time](/reference/enums#formats) | Read | Message's update time.
sent_at | [Time](/reference/enums#formats) | Read | Time when Message has been sent at.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been -> was, we know exact time

---------------------|---------|------------|------------
created_at | [Time](/reference/enums#formats) | Read | Message's create time.
updated_at | [Time](/reference/enums#formats) | Read | Message's update time.
sent_at | [Time](/reference/enums#formats) | Read/Write | Time when Message has been sent at.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been -> was, we know the exact time

conversation_id | String | Write | Message's conversation id.
sender_id | String | Write | Message's sender id.
---------------------|---------|------------|------------
channel | String | Read/Write | Message's channel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel, origin and visibility should link to some enums

member_id | Integer | Read/Write | Participant's Member id.
conversation_id | Integer | Read/Write | Participant's Conversation id.
---------------------|---------|------------|------------
read | Boolean | Read/Write | Is related to Participant's read_at attribute.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read is write only, read_at is both read/write, but read is really the same as sending read_at with Time.current

@adamgrad
Copy link
Member Author

@Azdaroth feedback is here. I'll submit hosts endpoint in separate PR as you suggested

Copy link
Member

@Azdaroth Azdaroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor change

bookingsync_inbox | BookingSync Inbox
airbnb_message | Airbnb message
airbnb_email | Airbnb email
booking-com | booking.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booking.com in the origin should be capitalised, especially if it's one our more biggest partners :P

@adamgrad
Copy link
Member Author

@Azdaroth fixed and resolved conflicts

Copy link
Member

@Azdaroth Azdaroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🐉 Opa!

@Azdaroth Azdaroth merged commit f907b47 into master Dec 27, 2018
@Azdaroth Azdaroth deleted the CORE-793-add-inbox-attachments-docs branch December 27, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants