Update fees and rentals_fees endpoints with new actions and attributes #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenCocoon
requested changes
Feb 9, 2017
| { | ||
| "fees": [ | ||
| { | ||
| "name":{ |
There was a problem hiding this comment.
On write, it need to use name_en instead.
| { | ||
| "fee_id": 9, | ||
| "always_applied": true, | ||
| "maximum_bookable": 12 |
There was a problem hiding this comment.
No need to define if public, private or required?
|
|
||
| ## Destroy a fee | ||
|
|
||
| Required OAuth scope: `:rates_write` |
There was a problem hiding this comment.
I think good to explain that it's really getting archived and looking at archived_at is the way to identify if a fee should not longer be considered as valid.
There was a problem hiding this comment.
Why do we even return archived fees?
There was a problem hiding this comment.
cause we might still have links to them from bookings_fees.
| public | Boolean | Read | Publicly bookable by client if set to true. | ||
| rate | [Decimal](/reference/enums#formats) | Read | Rentals Fee's rate. | ||
| rate_kind | String | Read | Rentals Fee's rate kind, list of fee's rate kinds described in [enums section](/reference/enums#fee-rate-kinds). | ||
| required | Boolean | Read | Always included for new bookings, also public if set to true. |
| always_applied | Boolean | Read/Write | Available to all seasons and periods if set to true. | ||
| maximum_bookable | Integer | Read/Write | Rentals Fee's maximum booked count. | ||
| name | [Object](/reference/enums#formats) | Read | Rentals Fee's name, list of locales described in [enums section](/reference/enums#locales). | ||
| public | Boolean | Read | Publicly bookable by client if set to true. |
There was a problem hiding this comment.
ok, on admin v2 it's using status, should be here as well then. Needed to set this.
| rate | [Decimal](/reference/enums#formats) | Read | Rentals Fee's rate. | ||
| rate_kind | String | Read | Rentals Fee's rate kind, list of fee's rate kinds described in [enums section](/reference/enums#fee-rate-kinds). | ||
| required | Boolean | Read | Always included for new bookings, also public if set to true. | ||
| -----------------|---------|------------|------------ |
There was a problem hiding this comment.
Missing private, which is writable as well
ZenCocoon
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.