Skip to content

Add LICENSE.txt #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2021
Merged

Add LICENSE.txt #1

merged 5 commits into from
Oct 19, 2021

Conversation

Stannislav
Copy link
Contributor

No description provided.

@Stannislav Stannislav requested a review from EmilieDel October 19, 2021 07:50
@Stannislav Stannislav self-assigned this Oct 19, 2021
EmilieDel
EmilieDel approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@EmilieDel EmilieDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, do we need to put a header in every file for the license ?

@Stannislav
Copy link
Contributor Author

Btw, do we need to put a header in every file for the license ?

Good point! I'll add them

@Stannislav
Copy link
Contributor Author

I'm wondering how to handle the license notice header for the vendored files. I found some examples where the license of the vendor is displayed:

Some GitHub issues discussing a similar question:

@EmilieDel
Copy link
Contributor

Good point! I can imagine we can display the vendor's license, yes.

@Stannislav Stannislav merged commit 2b11636 into main Oct 19, 2021
@Stannislav Stannislav deleted the add-license branch October 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilieDel EmilieDel EmilieDel approved these changes

Assignees

@Stannislav Stannislav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stannislav @EmilieDel