This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Allow NetSendBuffer_t to grow #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now NetSendBuffer_t was allocated at a fixed size that could not be changed. When using buffered net_send and invoking multiple net_send's in INITIAL blocks in NMODL it may happen that we run out of buffer. Currently this case is not handled and causes a buffer overflow. As a first step NetSendBuffer_t has been given a constructor and destructor as well as a grow function that doubles all internal buffer sizes and copies data to the new buffers.
nrnhines
reviewed
Oct 3, 2020
pramodk
reviewed
Oct 4, 2020
nrnhines
reviewed
Oct 4, 2020
Updated destructor to use free wrapper for cuda compatibility.
|
please retest |
added 2 commits
October 5, 2020 12:05
By inheriting from MemoryManaged the class overloads new and free operators to use cudaMallocManaged alloctors when necessary.
- fixed a bug, _size was not being updated - Check for OpenACC and throw an error, as reallocation will not work on device
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
Until now NetSendBuffer_t was allocated at a fixed size that could not be changed. When using buffered net_send and invoking multiple net_send's in INITIAL blocks in NMODL it may happen that we run out of buffer. Currently this case is not handled and causes a buffer overflow. As a first step NetSendBuffer_t has been given a constructor and destructor as well as a grow function that doubles all internal buffer sizes and copies data to the new buffers. - By inheriting from MemoryManaged the class overloads new and free operators to use cudaMallocManaged alloctors when necessary. - Check for OpenACC and throw an error, as reallocation will not work on device CoreNEURON Repo SHA: BlueBrain/CoreNeuron@639e9e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now NetSendBuffer_t was allocated at a fixed size that could not
be changed. When using buffered net_send and invoking multiple
net_send's in INITIAL blocks in NMODL it may happen that we run out of
buffer. Currently this case is not handled and causes a buffer overflow.
As a first step NetSendBuffer_t has been given a constructor and
destructor as well as a grow function that doubles all internal buffer
sizes and copies data to the new buffers.