Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 10, 2020

No description provided.

@bbpbuildbot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@pramodk
Copy link
Collaborator

pramodk commented Aug 10, 2020

Ahh..Phase2::handle_extracon contain logic of setting up weight vectors and that was causing an issue. Ok!

@pramodk pramodk closed this Aug 11, 2020
@pramodk pramodk reopened this Aug 11, 2020
@alkino alkino changed the title Remove extracon and multiple Remove extracon and multiple, #fix 291 Aug 11, 2020
@alkino alkino changed the title Remove extracon and multiple, #fix 291 Remove extracon and multiple, fix #291 Aug 11, 2020
@pramodk pramodk merged commit 5fb8978 into master Aug 11, 2020
@pramodk pramodk deleted the remove_extracon branch August 11, 2020 07:37
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
…/CoreNeuron#360)

Extra-connection and module duplication functionality was added
to scale model for benchmarking. Over last few years we haven't used
this functionality as it's often easy to just scale the model and BBP
model's are already big. Hence no need to carry the old code.

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@5fb8978
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants