Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

pramodk
Copy link
Collaborator

@pramodk pramodk commented Oct 8, 2018

This allows specifying separate patternstim file for restore part:

  • start event chain by sending event at t+0
  • discard events from file that arrive before t

Here is internal ticket: https://bbpteam.epfl.ch/project/issues/browse/CNEUR-313

Current implementation of coreneuron expects whole spike-replay file provided on command line. We have fixed this by https://github.com/BlueBrain/CoreNeuron/pull/121.
But this might result in loss of spikes in case of:
  * user specify tstop = 100 for part0
  * simulator stop at 100.1
  * pattern.dat in part1 has event at 100.05
One way to avoid this error is to always provide whole pattern.dat file to coreneuron. Is that feasible solution? (note that the implementation in coreneuron needs to be updated to avoid storing whole file)

@nrnhines : do we need to consider above corner case?

@pramodk pramodk closed this Feb 6, 2019
@pramodk pramodk reopened this Feb 6, 2019
@pramodk pramodk closed this Feb 24, 2019
@pramodk pramodk reopened this Feb 24, 2019
@pramodk pramodk closed this Mar 24, 2019
@pramodk pramodk reopened this Mar 24, 2019
@pramodk pramodk force-pushed the fix/patternstim branch from db36558 to 0face0d Compare July 8, 2019 08:14
@pramodk pramodk requested a review from nrnhines July 8, 2019 09:48
@pramodk pramodk changed the title Patternstip fix : allow restore phases to provide new pattern-stim Patternstim fix : allow restore phases to provide new pattern-stim Jul 9, 2019
@pramodk
Copy link
Collaborator Author

pramodk commented Jul 9, 2019

@nrnhines : could you review this?

@bbpbuildbot
Copy link
Collaborator

Can one of the admins verify this patch?

@pramodk
Copy link
Collaborator Author

pramodk commented Jul 25, 2020

This should be merged after having test in CI

@pramodk pramodk merged commit b1ee4fa into master Aug 8, 2020
@pramodk pramodk deleted the fix/patternstim branch August 8, 2020 18:56
pramodk added a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
…lueBrain/CoreNeuron#121)

* Allow restore phases to provide new pattern stim via CLI
* Add save-restore test with patternstim
* NOTE : if restore pattern stim file has event at the checkpoint time
  boundary then the event could be missed. 
  See https://bbpteam.epfl.ch/project/issues/browse/CNEUR-313

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b1ee4fa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants