fix: respect user's default shell from SHELL env var #1105
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the shell selection logic hardcoded a preference for zsh over bash, ignoring the user's configured default shell. This changes the behavior to: 1. Check the SHELL environment variable first 2. Validate the shell exists and is supported 3. Fall back to bash or sh if SHELL is not set or invalid This ensures consistent shell behavior across the system and respects user preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1104
This PR updates the shell selection logic to respect the user's default shell from the
SHELLenvironment variable instead of hardcoding a preference for zsh over bash.Changes
get_shell_command()incrates/utils/src/shell.rsto:SHELLenvironment variable firstSHELLis not set or contains an unknown shellTesting
cargo fmt --checkcargo clippy --all --all-targets --all-features -- -D warningsBehavior
Before: Always prefers zsh if installed, regardless of user's default shell
After: Uses the shell specified in
SHELLenv var, falls back to bash/sh if not set