Side navigation menu doesn't work

[jpatrickburns]

... at least on a modern Mac, and latest OS (and Safari). Just checked, doesn't work in Chrome, either.

Clicking on the side menu links (to anchors) doesn't scroll to the right section of the document. Is the fancy scrolling stuff somehow messing up this fundamental behavior? BTW, the URL changes, it just doesn't go to that part of the document.

Bummer.

[tophtucker]

Just noticed this. Also, the black box at the top of the TOC heatmap is supposed to track scroll progress, but now it’s just stuck at the top.

This definitely worked originally lol! 😅 So I don’t think it’s any of the fancy stuff. I think we’re looking at document.body.scrollTop in some places where we should be looking at document.documentElement.scrollTop or window.scrollY.

I think scroll position isn't set on document.body in most modern browsers - it's usually set on document.documentElement now. See bugs.chromium.org/p/chromium/issues/detail?id=157855 for Chrome's transition. – fzzfzzfzz, May 3, 2018 at 15:51

[jpatrickburns]

You’re sending this to the wrong person. Stop it. James Burnsburnscomics.comOn Sep 4, 2024, at 5:52 PM, Toph Tucker ***@***.***> wrote: Just noticed this. Also, the black box at the top of the TOC heatmap is supposed to track scroll progress, but now it’s just stuck at the top. BC253516-8A91-4142-8FF6-AA7DAE2DB69D-676-0009506F7E2FD36E.png (view on web) This definitely worked originally lol! 😅 So I don’t think it’s any of the fancy stuff. I think we’re looking at document.body.scrollTop in some places where we should be looking at document.documentElement.scrollTop or window.scrollY. I think scroll position isn't set on document.body in most modern browsers - it's usually set on document.documentElement now. See bugs.chromium.org/p/chromium/issues/detail?id=157855 for Chrome's transition. – fzzfzzfzz, May 3, 2018 at 15:51 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>