Skip to content

Conversation

PJColombo
Copy link
Member

@PJColombo PJColombo commented Oct 11, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

It adds missing Sepolia's rollup sequencer addresses for the following: arbitrum, base, Linea and optimism.

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 5a8b71e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/rollups Minor
@blobscan/web Patch
@blobscan/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am
blobscan-staging ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:07am

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (6dcc800) to head (5a8b71e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/rollups/src/index.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files         153      153              
  Lines       10190    10204      +14     
  Branches     1141     1142       +1     
==========================================
+ Hits         9101     9115      +14     
  Misses       1089     1089              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.79 KB (🟡 +38.17 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 284.04 KB 81.15%
/stats 347.54 KB 631.33 KB 180.38%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.83 KB 635.62 KB 181.61% (🟢 -5.01%)
/address/[address] 26.95 KB 310.75 KB 88.79% (🟢 -4.80%)
/blob/[hash] 27.62 KB 311.42 KB 88.98% (🟢 -4.24%)
/blobs 76.74 KB 360.54 KB 103.01% (🟡 +12.55%)
/block/[id] 14.31 KB 298.1 KB 85.17% (🟢 -4.16%)
/blocks 74.44 KB 358.24 KB 102.35% (🟡 +12.54%)
/tx/[hash] 16.31 KB 300.1 KB 85.74% (🟡 +0.88%)
/txs 73.94 KB 357.74 KB 102.21% (🟡 +10.53%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PJColombo PJColombo merged commit c3cfd46 into main Oct 14, 2024
14 checks passed
@PJColombo PJColombo deleted the feat/db/add-missing-sepolia-rollups branch October 14, 2024 10:10
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
luis-herasme pushed a commit that referenced this pull request Oct 19, 2024
* feat(rollups): add missing sepolia rollups

* chore: add changeset
@PJColombo PJColombo restored the feat/db/add-missing-sepolia-rollups branch October 29, 2024 11:30
@PJColombo PJColombo deleted the feat/db/add-missing-sepolia-rollups branch October 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants