Skip to content

Conversation

gaelicWizard
Copy link
Contributor

Description

Apply shfmt, fix shellcheck, and simplify code flow by short-circuiting at the top rather than indenting the whole function definition in an if clause.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

And apply `shfmt` and fix `shellcheck`
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another @tbhaxor file, but we didn't break this one in a previous commit.

Converting to a proper array and using quoted reference is a good fix imo, so that part is approved.

However:

@gaelicWizard You're using ' in the array on this PR but " on the wpscan PR - Let's settle on one (I like ')

@gaelicWizard
Copy link
Contributor Author

using ' in the array on this PR but " on the wpscan PR - Let's settle on one (I like ')

I alsö like ' for this, but the string was already " so I just left it out of laziness. I'll switch it now

Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I can tell this is ready to go !

@NoahGorny NoahGorny merged commit 3757755 into Bash-it:master Sep 28, 2021
@gaelicWizard gaelicWizard deleted the completion-laravel branch September 29, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants