Skip to content

plugin/less-pretty-cat improvements #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2021
Merged

plugin/less-pretty-cat improvements #1957

merged 3 commits into from
Sep 28, 2021

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 19, 2021 •
edited
Loading

Description

Adopt _command_exists, quote variables, handle unbound parameters, code flow simplification.

Motivation and Context

This was part of my _command_exists branch (#1938) but was out of scope.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard changed the title DRAFT: plugin/less-pretty-cat improvements plugin/less-pretty-cat improvements Sep 20, 2021
@gaelicWizard gaelicWizard marked this pull request as ready for review September 20, 2021 05:20
davidpfarrell
davidpfarrell suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings all !

I have a few comments, many related to the core logic and not necessarily this PR

However : WHY ARE THERE 7 EMPTY FILES IN THIS PR?

If this is chained and waiting on another PR, let's mark it as a DRAFT until its ready.

@gaelicWizard gaelicWizard force-pushed the plugin-less-pretty-cat branch 3 times, most recently from fc8c2b9 to 5d9c97a Compare September 22, 2021 20:31
@gaelicWizard
Copy link
Contributor Author

Rebased on master

davidpfarrell
davidpfarrell suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good I think we're almost there !

@gaelicWizard
plugins/less-pretty-cat: use _command_exists
55be49e 
Addresses Bash-it#1632

Alsö, code style cleanup: quote variables, handle unbound parameters,  &c.
@gaelicWizard
plugins/less-pretty-cat: simplify code flow
5857648 
Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace.
davidpfarrell
davidpfarrell reviewed Sep 23, 2021
View reviewed changes
davidpfarrell
davidpfarrell approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move this one along ...

one last note: On cless, although the docs mention a single file, the code actually cats ALL files and then pipes the result to less. I'm not going to hold up the PR on that but just wanted to call it out ...

@gaelicWizard
plugin/less-pretty-cat: remove || cat
2ddb407 
The logic to run `cat` if `pygmentize` fails seems useless, so just remove it.
@gaelicWizard
Copy link
Contributor Author

Lets move this one along ...

one last note: On cless, although the docs mention a single file, the code actually cats ALL files and then pipes the result to less. I'm not going to hold up the PR on that but just wanted to call it out ...

tweaked and pushed 👍

@NoahGorny NoahGorny merged commit 127cbbd into Bash-it:master Sep 28, 2021
@gaelicWizard gaelicWizard deleted the plugin-less-pretty-cat branch September 29, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@davidpfarrell davidpfarrell davidpfarrell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaelicWizard @davidpfarrell @NoahGorny