Skip to content

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 17, 2021

Description

Despite indent_size being set to tab by default, it turns out that we set indent_size to 2 for * at the top of this file. So, for everywhere else, explicitly set indent_size to the default (tab). This should achieve the goal of my last patch to .editorconfig.

Motivation and Context

Linters and formatters are good; they make tedium easy. But, they need to be configured properly and it was my PR that removed the explicit indent_size=4.

This PR makes no formatting changes; just fixes my previous patch.

References

EditorConfig.org:

indent_style: set to tab or space to use hard tabs or soft tabs respectively.
indent_size: a whole number defining the number of columns used for each indentation level and the width of soft tabs (when supported). When set to tab, the value of tab_width (if specified) will be used.

How Has This Been Tested?

Testing? Where we're going, we don't need testing!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Despite `indent_size` being set to `tab` by default, it turns out that we set `indent_size` to `2` for `*` at the top of this file. So, for everywhere else, explicitly set `indent_size` to the default (`tab`). This should achieve the goal of my last patch to `.editorconfig`.
@gaelicWizard gaelicWizard marked this pull request as ready for review September 17, 2021 17:50
@NoahGorny NoahGorny merged commit b72588e into Bash-it:master Sep 18, 2021
@gaelicWizard gaelicWizard deleted the EditorTab branch September 18, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants