defaults: Revert to old comparison #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a small bug along the way :)
davidpfarrell
approved these changes
Aug 16, 2021
@NoahGorny Can't agree more. I've been focused on other stuff but would definitely like to circle back to what we consider "default" vs "general" vs "base". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a small bug along the way :)
Description
Revert back to straight comparison instead of regex one
Motivation and Context
Mistakenly added in #1913
I want to say that this file is seemingly broken in many ways already, so I did not bother fixing all of the other stuff
that did not work..
How Has This Been Tested?
Locally
Types of changes
Checklist: