Implement async setTimeout #844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymlipari
reviewed
Aug 2, 2021
|
|
||
| void Dispatch(std::shared_ptr<Napi::FunctionReference> func, std::chrono::system_clock::time_point time) | ||
| { | ||
| if (time <= std::chrono::system_clock::now()) |
There was a problem hiding this comment.
FYI, system_clock can roll backwards if the user adjusts their system clock. steady_clock is guaranteed to always progress forward. I'd recommend using steady_clock for everything here.
|
Now implemented in #1146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is a work in progress as I learn more about async programming
While taking CPU profiles of BabylonNative I noticed that
Window::RecursiveWaitOrCall(used by thesetTimeoutpolyfill) was taking up a bunch of cycles:This seemed to be due to the high number of
Dispatchcalls coming from the recursive loop.Now we're using a single worker thread with a condition variable and a priority queue, which allows us to both queue up delayed functions and preempt them, reducing the CPU load significantly.
fixes #843