Skip to content

Mocha&Chai update #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 25, 2025
Merged

Mocha&Chai update #1499

merged 18 commits into from
Apr 25, 2025

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Apr 8, 2025 •
edited
Loading

  • upgrade Mocha and Chai version
  • dump exception error object properties (works well with Chakra)
  • use Babel to translate ES module to umd
  • replace bigint notation (with n suffix) unsupported by Chakra
  • script loading tweaks for unittests to support globalThis and Chai exports

@CedricGuillemet CedricGuillemet marked this pull request as draft April 8, 2025 16:49
@CedricGuillemet CedricGuillemet mentioned this pull request Apr 23, 2025
Closed
@CedricGuillemet CedricGuillemet marked this pull request as ready for review April 23, 2025 15:20
bghgary
bghgary reviewed Apr 23, 2025
View reviewed changes
@CedricGuillemet CedricGuillemet enabled auto-merge (squash) April 25, 2025 16:26
@CedricGuillemet CedricGuillemet merged commit 720b77a into BabylonJS:master Apr 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

@ryantrem ryantrem Awaiting requested review from ryantrem

@SergioRZMasson SergioRZMasson Awaiting requested review from SergioRZMasson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CedricGuillemet @bghgary