-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Viewer v2: Switch back to WebGL as the default for now #16946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/tools/viewer-configurator/src/components/babylonViewer/viewer.tsx
Outdated
Show resolved
Hide resolved
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16946/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16946/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16946/merge#BCU1XR#0 |
Warn for bad qsp
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Unfortunately we've hit some reliability issues with WebGPU + snapshot rendering that are difficult to repro and seem to be timing related. We need to investigate more, but the quick fix to make sure the Viewer is stable is to switch back to WebGL as the default for now. Might wait for @Popov72 availability for deeper investigation. I also added a query param for the Viewer Configurator so that in that context its easy to test both WebGL and WebGPU.
Unfortunately we've hit some reliability issues with WebGPU + snapshot rendering that are difficult to repro and seem to be timing related. We need to investigate more, but the quick fix to make sure the Viewer is stable is to switch back to WebGL as the default for now. Might wait for @Popov72 availability for deeper investigation. I also added a query param for the Viewer Configurator so that in that context its easy to test both WebGL and WebGPU.
Unfortunately we've hit some reliability issues with WebGPU + snapshot rendering that are difficult to repro and seem to be timing related. We need to investigate more, but the quick fix to make sure the Viewer is stable is to switch back to WebGL as the default for now. Might wait for @Popov72 availability for deeper investigation.
I also added a query param for the Viewer Configurator so that in that context its easy to test both WebGL and WebGPU.