Inspector v2: Make properties services and component structure consistent and stub out services for the rest of the entity types #16943
+239
−199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consistent pattern now is:
texturePropertiesService.tsx
,nodePropertiesService.tsx
, etc.nodeProperties.tsx
,abstractMeshProperties.tsx
,meshProperties.tsx
, etc.AbstractMeshGeneralProperties
,AbstractMeshAdvancedProperties
(both inabstractMeshProperties.tsx
).So far this seems to be a good balance of not too many files, and files not being too big.
I also stubbed out the *PropertiesService.tsx files for the remaining top level entity types.