Skip to content

Inspector v2: Make properties services and component structure consistent and stub out services for the rest of the entity types #16943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

ryantrem
Copy link
Member

The consistent pattern now is:

  • One properties service definition / file per top level entity type (as defined by scene, e.g. scene. Textures, scene.rootNodes, etc.). For example, texturePropertiesService.tsx, nodePropertiesService.tsx, etc.
  • One file per concrete entity of the class hierarchy. For example, nodeProperties.tsx, abstractMeshProperties.tsx, meshProperties.tsx, etc.
  • One react component per concrete entity per section. For example, AbstractMeshGeneralProperties, AbstractMeshAdvancedProperties (both in abstractMeshProperties.tsx).

So far this seems to be a good balance of not too many files, and files not being too big.

I also stubbed out the *PropertiesService.tsx files for the remaining top level entity types.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@ryantrem ryantrem enabled auto-merge (squash) July 30, 2025 21:59
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16943/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16943/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16943/merge/?snapshot=refs/pull/16943/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 30, 2025

@ryantrem ryantrem merged commit 8c10346 into BabylonJS:master Jul 30, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants