Inspector v2: Add useResource hook and use it to correctly manage some object lifetimes in stats #16917
Conversation
Don't register animation callback when there are no animations
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16917/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16917/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16917/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16917/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16917/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
One challenge with React function components is managing lifetimes of disposable resources. I noticed that my previous implementation in stats was totally wrong and recreating a ton of
SceneInstrumentationandEngineInstrumentationinstances that were never disposed. I have more cases of this kind of resource management as well, so I'm introducing auseResourcecustom hook that makes it easy to correctly manage disposable resources in a React function component, and using this in stats.Also, I included one other small fix that prevents registering for the animation callback for animation properties when the entity has no animations.