Skip to content

[Fluent] Add floating Search Box to graph canvas #16911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025

Conversation

georginahalpern
Copy link
Contributor

  • Rename SearchBox to SearchBar (the bar where user can type to filter content)
  • Introduce SearchBox component and PositionedPopover components, allowing us to show/hide a searchbox at specified location in the UX
  • Conditionally use fluent SearchBox wrapped in a PositionedPopover from within nodegraph tools
  • Fix DraggableLine styling to look more polished (though we will still do a full styling pass)
  • Though not used yet, added comboBox component in case that is the preferred UX
image image

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16911/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16911/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16911/merge/?snapshot=refs/pull/16911/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 22, 2025

@sebavan sebavan enabled auto-merge (squash) July 22, 2025 17:41
@sebavan sebavan merged commit 1baf7f7 into BabylonJS:master Jul 22, 2025
20 checks passed
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
- Rename SearchBox to SearchBar (the bar where user can type to filter
content)
- Introduce SearchBox component and PositionedPopover components,
allowing us to show/hide a searchbox at specified location in the UX
- Conditionally use fluent SearchBox wrapped in a PositionedPopover from
within nodegraph tools
- Fix DraggableLine styling to look more polished (though we will still
do a full styling pass)
- Though not used yet, added comboBox component in case that is the
preferred UX
<img width="784" height="722" alt="image"
src="https://github.com/user-attachments/assets/1ae93cc1-c8a8-41bb-99ec-05295bb21d33"
/>
<img width="210" height="134" alt="image"
src="https://github.com/user-attachments/assets/3762dd7f-fd58-4221-b746-ffd8d46738ee"
/>

---------

Co-authored-by: Georgina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants