Skip to content

Fix sandbox loading issue #16890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

Fix sandbox loading issue #16890

merged 3 commits into from
Jul 16, 2025

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Jul 16, 2025

Fix #16887

@deltakosh deltakosh enabled auto-merge (squash) July 16, 2025 20:58
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Reviewer - this PR has made changes to the build configuration file.

This build will release a new package on npm

If that was unintentional please make sure to revert those changes or close this PR.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Reviewer - this PR has made changes to the build configuration file.

This build will release a new package on npm

If that was unintentional please make sure to revert those changes or close this PR.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16890/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16890/merge/?snapshot=refs/pull/16890/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16890/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16890/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

Reviewer - this PR has made changes to the build configuration file.

This build will release a new package on npm

If that was unintentional please make sure to revert those changes or close this PR.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16890/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16890/merge/?snapshot=refs/pull/16890/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16890/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 16, 2025

@deltakosh deltakosh merged commit 8078b55 into master Jul 16, 2025
19 of 20 checks passed
@deltakosh deltakosh deleted the sandbox-fix branch July 16, 2025 23:05
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sandbox instability
4 participants