Skip to content

Inspector v2: Add scene node to scene explorer #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ryantrem
Copy link
Member

Two things in this PR:

  1. Add a top level scene node to scene explorer.
  2. Replace the scene explorer section "watch" function with just an array of observables. This is what I originally wanted to do, but it was hard to do because of the lack of covariance in Observable. It's now easy to do with the covariant IReadonlyObservable.

image

@ryantrem ryantrem requested a review from georginahalpern June 20, 2025 16:55
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@ryantrem ryantrem merged commit ab8dd7e into BabylonJS:master Jun 20, 2025
18 checks passed
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
Two things in this PR:
1. Add a top level scene node to scene explorer.
2. Replace the scene explorer section "watch" function with just an
array of observables. This is what I originally wanted to do, but it was
hard to do because of the lack of covariance in Observable<T>. It's now
easy to do with the covariant IReadonlyObservable<T>.


![image](https://github.com/user-attachments/assets/ba8b106e-3afa-4907-8b03-0ec6f8506362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants