Skip to content

Various fixes for glTF interactivity #16768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Jun 18, 2025

  • Added support for operations involving Quaternion and Vector4 types in FlowGraphAddBlock, FlowGraphSubtractBlock, FlowGraphMultiplyBlock, and FlowGraphDivideBlock. Returns Vector4 when the inputs are mixed types.
  • Added logic to stop running animations when setting properties in FlowGraphSetPropertyBlock, preventing conflicts with ongoing animations. This is buried in the spec 4.1.4.2.4, step 5 and 4.1.4.2.5, step 8.
  • Fixed incorrect code that causes a script error in FlowGraphSetVariableBlock that stop animations targeting the same variable.

@bghgary bghgary requested a review from SergioRZMasson June 18, 2025 21:12
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 18, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 18, 2025

@bghgary bghgary marked this pull request as draft June 18, 2025 21:41
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 18, 2025

@bghgary
Copy link
Contributor Author

bghgary commented Jun 18, 2025

Will do some tests against the snapshot before merging.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 18, 2025

@bghgary bghgary marked this pull request as ready for review June 18, 2025 21:53
@bghgary bghgary merged commit efcf01f into BabylonJS:master Jun 18, 2025
18 checks passed
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
* Added support for operations involving `Quaternion` and `Vector4`
types in `FlowGraphAddBlock`, `FlowGraphSubtractBlock`,
`FlowGraphMultiplyBlock`, and `FlowGraphDivideBlock`. Returns `Vector4`
when the inputs are mixed types.
* Added logic to stop running animations when setting properties in
`FlowGraphSetPropertyBlock`, preventing conflicts with ongoing
animations. This is buried in [the
spec](https://github.com/KhronosGroup/glTF/blob/interactivity/extensions/2.0/Khronos/KHR_interactivity/Specification.adoc)
`4.1.4.2.4, step 5` and `4.1.4.2.5, step 8`.
* Fixed incorrect code that causes a script error in
`FlowGraphSetVariableBlock` that stop animations targeting the same
variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants