Skip to content

Fix inspector bugs where animation target name gets cut off and clicking on it does not link to target #16705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix inspector bugs where animation target name gets cut off and clicking on it does not link to target #16705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nents/actionTabs/tabs/propertyGrids/animations/targetedAnimationPropertyGridComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export class TargetedAnimationGridComponent extends React.Component<ITargetedAni
<TextLineComponent
label="Target"
value={targetedAnimation.target.name}
onLink={() => this.props.globalState.onSelectionChangedObservable.notifyObservers(targetedAnimation)}
onLink={() => this.props.globalState.onSelectionChangedObservable.notifyObservers(targetedAnimation.target)}
/>
)}
{this._animationCurveEditorContext && <AnimationCurveEditorComponent globalState={this.props.globalState} context={this._animationCurveEditorContext} />}
Expand Down
5 changes: 3 additions & 2 deletions packages/dev/sharedUiComponents/src/lines/textLineComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,17 @@ export class TextLineComponent extends React.Component<ITextLineComponentProps>
if (this.props.ignoreValue) {
return null;
}
const title = this.props.tooltip ?? this.props.value ?? this.props.label ?? "";

if (this.props.onLink || this.props.url) {
return (
<div className="link-value" title={this.props.tooltip ?? this.props.label ?? ""} onClick={() => this.onLink()}>
<div className="link-value" title={title} onClick={() => this.onLink()}>
{this.props.url ? "doc" : this.props.value || "no name"}
</div>
);
}
return (
<div className="value" title={this.props.tooltip ?? this.props.label ?? ""} style={{ color: this.props.color ? this.props.color : "" }}>
<div className="value" title={title} style={{ color: this.props.color ? this.props.color : "" }}>
{this.props.value || "no name"}
</div>
);
Expand Down
Loading