Skip to content

Viewer: small fixes to test apps #16680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

ryantrem
Copy link
Member

This PR has a few small fixes to the Viewer test apps:

  1. Add the addons package to the vite config (needed for inspector)
  2. Remove @Preview in the public package test html
  3. Remove the environment attribute (use the default embedded one instead)

@ryantrem ryantrem added the bug label May 27, 2025
@ryantrem ryantrem requested a review from RaananW May 27, 2025 17:15
@ryantrem ryantrem enabled auto-merge (squash) May 27, 2025 17:15
@bjsplat
Copy link
Collaborator

bjsplat commented May 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 27, 2025

@ryantrem ryantrem merged commit 192c1f0 into BabylonJS:master May 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants