Skip to content

instancedMesh: optimize initialization performance #16648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

kzhsw
Copy link
Contributor

@kzhsw kzhsw commented May 21, 2025

In the constructor of InstancedMesh, refreshBoundingInfo if called, but if the source mesh does not contain skeleton or morphTargetManager, we can use bounding info of source mesh directly, to avoid overheads introduced by refreshBoundingInfo.

Forum post: https://forum.babylonjs.com/t/instancedmesh-why-fully-refreshboundinginfo-even-without-bones/58543

In the constructor of InstancedMesh, refreshBoundingInfo if called, but if the source mesh does not contain skeleton or morphTargetManager, we can use bounding info of source mesh directly, to avoid overheads introduced by refreshBoundingInfo.

Forum post: <https://forum.babylonjs.com/t/instancedmesh-why-fully-refreshboundinginfo-even-without-bones/58543>
@bjsplat
Copy link
Collaborator

bjsplat commented May 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 21, 2025

@RaananW RaananW merged commit 52da366 into BabylonJS:master May 21, 2025
17 checks passed
@kzhsw kzhsw deleted the patch-1 branch May 22, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants