Skip to content

Skip SVG processing if no window/document or SVG support. #16623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

jamessimo
Copy link
Contributor

In edge cases where BabylonJS is being ran in a Windowless/DOM-less environment, creation of images fails due to the "Check SVG" requiring a DOM to work. Just added a catch to find if you don't have a window and return the same value.

@bjsplat
Copy link
Collaborator

bjsplat commented May 18, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 18, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 18, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 18, 2025

@deltakosh deltakosh enabled auto-merge (squash) May 19, 2025 17:57
@bjsplat
Copy link
Collaborator

bjsplat commented May 19, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 19, 2025

@deltakosh deltakosh merged commit 6b973b3 into BabylonJS:master May 19, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants