Skip to content

Adding handling of InstacedMesh inside of addAllAssetsToContainer that was missing. #16601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

VicenteCartas
Copy link
Contributor

AssetContainer.addAllAssetsToContainer was missing handling InstancedMeshes, so when one of those meshes existed in the node hierarchy, it was getting added to the transformNodes list instead of the meshes list.

@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 14, 2025

@sebavan sebavan merged commit 6a5d2c1 into BabylonJS:master May 14, 2025
17 checks passed
RolandCsibrei pushed a commit to RolandCsibrei/Babylon.js that referenced this pull request May 15, 2025
…t was missing. (BabylonJS#16601)

AssetContainer.addAllAssetsToContainer was missing handling
InstancedMeshes, so when one of those meshes existed in the node
hierarchy, it was getting added to the transformNodes list instead of
the meshes list.
VicenteCartas added a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
…t was missing. (BabylonJS#16601)

AssetContainer.addAllAssetsToContainer was missing handling
InstancedMeshes, so when one of those meshes existed in the node
hierarchy, it was getting added to the transformNodes list instead of
the meshes list.
@VicenteCartas VicenteCartas deleted the container-instances branch August 7, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants