Skip to content

Fixes Area Lights for NME #16577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SergioRZMasson
Copy link
Contributor

The samplers required by Area Lights are placed in files that might not always be included when using NME. I'm moving them to always be paired with the appropriate area Lights functions to make sure we always have the samplers available.

Fixes issue reported from forum: https://forum.babylonjs.com/t/triplanar-node-material-area-lights-issue/58296

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

@deltakosh deltakosh merged commit de5a6aa into BabylonJS:master May 7, 2025
17 checks passed
RolandCsibrei pushed a commit to RolandCsibrei/Babylon.js that referenced this pull request May 15, 2025
The samplers required by Area Lights are placed in files that might not
always be included when using NME. I'm moving them to always be paired
with the appropriate area Lights functions to make sure we always have
the samplers available.

Fixes issue reported from forum:
https://forum.babylonjs.com/t/triplanar-node-material-area-lights-issue/58296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants