Skip to content

IFlowable added #16570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 8, 2025
Merged

IFlowable added #16570

merged 27 commits into from
May 8, 2025

Conversation

RolandCsibrei
Copy link
Contributor

Added an IFlowable interface and the FlowMap:public processFlowable(flowable: IFlowable, strength = 1, flowMapSamplePosOrTransformationMatrix?: IVector3Like | Matrix) function.

RolandCsibrei and others added 22 commits December 8, 2024 18:24
@RolandCsibrei
GRL OIT support
3e19860
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
3afac98
@RolandCsibrei
GREASED_LINE_USE_OFFSETS - WebGPU fix for Safari/Firefox
f827be6
@RolandCsibrei
Merge branch 'master' of github.com:RolandCsibrei/Babylon.js
28ccf29
@RolandCsibrei
Merge branch 'BabylonJS:master' into master
01e6c9f
@RolandCsibrei
added check for null/undefined offsets array
8247e43
@RolandCsibrei
Merge branch 'master' of github.com:RolandCsibrei/Babylon.js
ae1a04d
@RolandCsibrei
fixed jdoc
fd5cadf
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
aa1c0a7
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
60ffdf2
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
0e03efb
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
2c32b07
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
e153d2e
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
7f2ac0f
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
1e670cb
@RolandCsibrei
GRL colorsTexture fix
7b299fc
@RolandCsibrei
this._scene fix
dec1a37
@RolandCsibrei
fixed WebGPU GreasedLineSimpleMaterial colors texture assignment
e7aca48
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
9595ebe
@RolandCsibrei
Merge branch 'master' of github.com:BabylonJS/Babylon.js
076e49a
@RolandCsibrei
gpuPicker optimizations
0d9c299
@RolandCsibrei
IFlowable added
5fdb343
@RolandCsibrei RolandCsibrei marked this pull request as draft May 6, 2025 05:41
@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RolandCsibrei RolandCsibrei marked this pull request as ready for review May 6, 2025 16:54
@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

deltakosh
deltakosh reviewed May 6, 2025
View reviewed changes
@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Snapshot stored with reference name:
refs/pull/16570/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16570/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16570/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16570/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16570/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16570/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgpuplaywright/index.html

RolandCsibrei
RolandCsibrei commented May 6, 2025
View reviewed changes
@deltakosh deltakosh enabled auto-merge (squash) May 6, 2025 23:53
auto-merge was automatically disabled May 8, 2025 18:29

Head branch was pushed to by a user without write access

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2025

Snapshot stored with reference name:
refs/pull/16570/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16570/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16570/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16570/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16570/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16570/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16570/merge/testResults/webgl2playwright/index.html

@deltakosh deltakosh enabled auto-merge (squash) May 8, 2025 23:17
@deltakosh deltakosh merged commit f05f088 into BabylonJS:master May 8, 2025
17 checks passed
RolandCsibrei added a commit to RolandCsibrei/Babylon.js that referenced this pull request May 15, 2025
@RolandCsibrei
IFlowable added (BabylonJS#16570)
7e1fb9f 
Added an `IFlowable` interface and the `FlowMap:public
processFlowable(flowable: IFlowable, strength = 1,
flowMapSamplePosOrTransformationMatrix?: IVector3Like | Matrix)`
function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW left review comments

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RolandCsibrei @bjsplat @deltakosh @RaananW