Skip to content

Rendering Pipelines: Fix dispose #16543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 30, 2025
Merged

Rendering Pipelines: Fix dispose #16543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3da4313
Add support for .exr files
Popov72 Apr 9, 2025
aff4ef7
Merge branch 'master' of https://github.com/Popov72/Babylon.js
Popov72 Apr 10, 2025
92107c7
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 10, 2025
d6ba9cd
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 11, 2025
b6c3984
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 14, 2025
9fc6a72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 14, 2025
a096a47
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 24, 2025
5f3e196
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 28, 2025
9a3e3bf
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Apr 30, 2025
707b65f
Fix dispose of render pipeline
Popov72 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/lensRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,8 @@ export class LensRenderingPipeline extends PostProcessRenderPipeline {
public override dispose(disableDepthRender: boolean = false): void {
this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._scene.cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

(<any>this._chromaticAberrationPostProcess) = null;
(<any>this._highlightsPostProcess) = null;
(<any>this._depthOfFieldPostProcess) = null;
Expand Down
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/ssao2RenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,8 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {

this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._scene.cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

super.dispose();
}

Expand Down
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/ssaoRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@ export class SSAORenderingPipeline extends PostProcessRenderPipeline {

this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._scene.cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

super.dispose();
}

Expand Down
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/ssrRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,8 @@ export class SSRRenderingPipeline extends PostProcessRenderPipeline {

this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

this._thinSSRRenderingPipeline.dispose();

super.dispose();
Expand Down
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/standardRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,6 +1636,8 @@ export class StandardRenderingPipeline extends PostProcessRenderPipeline impleme

this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

super.dispose();
}

Expand Down
2 changes: 2 additions & 0 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/taaRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ export class TAARenderingPipeline extends PostProcessRenderPipeline {

this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._cameras);

this._scene.postProcessRenderPipelineManager.removePipeline(this._name);

this._ping.dispose();
this._pong.dispose();

Expand Down
Loading